TST: add explicit support for Python 3.14#1684
TST: add explicit support for Python 3.14#1684neutrinoceros wants to merge 1 commit intopypa:mainfrom
Conversation
490c8c8 to
c16aecf
Compare
|
Thanks for the contribution, but it looks like some of the test dependencies haven't supported Python 3.14 yet. 👀 |
|
Indeed. I didn't identify this issue locally because apparently I ran the test suite on the only platform where everything builds fine (macOS). Let me list the issues I'm parsing from log here:
|
|
the relevant PR upstream is already merged theacodes/cmarkgfm#77 |
|
The remaining failure looks genuine to me. I even think it was probably already discovered once, but hidden away by updating the test itself instead of fixing the bug (#1647). Of course, this is just my conclusion from a very quick review, and I could be entirely mistaken. |
|
Looks like issues are essentially caused by pycowsay not working on Windows with newer Python. Probably a good idea to fix the tests to use a different package instead. |
|
Hum, that's really surprising for a package that has a pure-python wheel. The log from CI is not particularly useful however is there any way I could retrieve this file or see its content ? |
4279653 to
5cc32a6
Compare
c16aecf to
d976517
Compare
|
fixed |
|
Cannot replicate the |
|
I'm aware. This is already being discussed above. I don't plan to dig further myself at the moment, so if that's what drafting the PR signals, you might as well just close it. |
changelog.d/(if the patch affects the end users)Summary of changes
Test plan
Tested by running